Skip to content

*_filter methods are deprecated in Rails 5 #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
twe4ked opened this issue Jan 23, 2016 · 2 comments
Closed

*_filter methods are deprecated in Rails 5 #450

twe4ked opened this issue Jan 23, 2016 · 2 comments

Comments

@twe4ked
Copy link

twe4ked commented Jan 23, 2016 

DEPRECATION WARNING: before_filter is deprecated and will be removed in Rails 5.1. Use before_action instead.

Looks like these were brought back in abf0843 as part of #356. The commit also looks like it hides warnings in tests.

Relevant code can be found here.
@twe4ked twe4ked mentioned this issue Jan 23, 2016
Closed
17 tasks
@twe4ked
Copy link
Author

twe4ked commented Jan 23, 2016

Duplicate of #404.

@twe4ked twe4ked closed this as completed Jan 23, 2016
@rmosolgo
Copy link
Member

I think the fix could be as straightforward as a respond_to? check in that code -- if the controller responds to before_action, use that, otherwise, use before_filter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@twe4ked @rmosolgo