Skip to content

Get tests passing #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,25 @@
language: ruby
sudo: required
dist: trusty
dist: xenial
addons:
chrome: stable
cache:
bundler: true
yarn: true
rvm:
- 2.7.0
- 2.6.5
- 2.5.7
# TODO: Ruby 3.0 requires the rexml gem adding to the Gemfile
# - 3.0
- 2.7
- 2.6
- 2.5
- jruby-9.1.9.0

gemfile:
# These have webpacker:
- gemfiles/rails_5.2_no_sprockets.gemfile
- gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile
- gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
- gemfiles/rails_5.2_no_sprockets_webpacker_5.gemfile
# These don't have webpacker:
- gemfiles/rails_5.2_sprockets_3.gemfile
- gemfiles/rails_5.2_sprockets_4.gemfile
Expand All @@ -25,19 +28,19 @@ matrix:
fast_finish: true
exclude:
# Oldest rails does not run on ruby 2.6
- rvm: 2.6.5
- rvm: 2.5.7
- rvm: 2.6
- rvm: 2.5
- rvm: jruby-9.1.9.0

include:
# Newest gemfiles for universal testing
- rvm: 2.6.5
- rvm: 2.6
gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
- rvm: 2.6.5
- rvm: 2.6
gemfile: gemfiles/rails_5.2_sprockets_4.gemfile
- rvm: 2.5.7
- rvm: 2.5
gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
- rvm: 2.5.7
- rvm: 2.5
gemfile: gemfiles/rails_5.2_sprockets_4.gemfile
- rvm: jruby-9.1.9.0
gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
Expand Down
13 changes: 12 additions & 1 deletion Appraisals
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Notes;
# 1) 'no_sprockets' in an appraisal name affects the setup for the tests.
# See SprocketsHelpers.available? in test/support/sprockets_helpers.rb

appraise 'rails-5.2-sprockets_4' do
gem 'rails', '~> 5.2.x'
gem 'sprockets', '~> 4.0.x'
gem 'sprockets', '~> 4.0'
gem 'turbolinks', '~> 5'
gem 'mini_racer', :platforms => :mri
gem 'therubyrhino', :platforms => :jruby
Expand Down Expand Up @@ -28,6 +32,13 @@ appraise 'rails-5.2_no_sprockets_webpacker_4' do
gem 'therubyrhino', :platforms => :jruby
end

appraise 'rails-5.2_no_sprockets_webpacker_5' do
gem 'rails', '~> 5.2.x'
gem 'webpacker', '~> 5.0'
gem 'mini_racer', :platforms => :mri
gem 'therubyrhino', :platforms => :jruby
end

appraise 'rails-5.2-no_sprockets' do
# Appraisal adds `turbolinks` to this gemfile because it is
# present in `./Gemfile`.
Expand Down
Loading