Skip to content

Get tests passing #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Get tests passing #1114

wants to merge 6 commits into from

Conversation

jrmhaig
Copy link

@jrmhaig jrmhaig commented May 2, 2021

Summary

WIP

Updating to get the tests working and updated for new versions of Ruby and Rails.

Other Information

  • Update mimemagic in Gemfile.lock. The currently linked version was yanked.
  • Update the Ubuntu image for Travis. Chrome depends on at least Xenial.

To do (help needed)

The tests are failing with the rails_5.2_no_sprockets_webpacker_* gemfiles:

module.js:550
    throw err;
    ^
Error: Cannot find module 'webpack-cli/bin/config-yargs'
    at Function.Module._resolveFilename (module.js:548:15)
    at Function.Module._load (module.js:475:25)
    at Module.require (module.js:597:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/travis/build/reactjs/react-rails/test/dummy_webpacker3/node_modules/webpack-dev-server/bin/webpack-dev-server.js:84:1)
    at Module._compile (module.js:653:30)
    at Object.Module._extensions..js (module.js:664:10)
    at Module.load (module.js:566:32)
    at tryModuleLoad (module.js:506:12)
    at Function.Module._load (module.js:498:3)
Killed.

It look as though the way to start webpack has changed from webpack-dev-server to webpack server but I don't understand the codebase enough to know what needs updating for this.

For reference: webpack/webpack-dev-server#2759

Main purpose is to update mimemagic as the version in the lock file was yanked
from Rubygems.
@jrmhaig jrmhaig force-pushed the get_tests_passing branch 6 times, most recently from d887a4b to 74a3830 Compare May 2, 2021 20:29
jrmhaig added 2 commits May 2, 2021 22:23
Chrome addon requires >= xenial
@jrmhaig jrmhaig force-pushed the get_tests_passing branch from 06b5f0c to 49e33a4 Compare May 2, 2021 21:23
kylemellander added a commit to kylemellander/react-rails that referenced this pull request Nov 14, 2021
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running.

This update was first started in reactjs#1114.
@justin808
Copy link
Collaborator

@jrmhaig can you please resolve conflicts?

We really need to switch to GH Actions.

@jrmhaig jrmhaig marked this pull request as ready for review August 17, 2022 10:24
@jrmhaig
Copy link
Author

jrmhaig commented Aug 17, 2022

Sorry, I pressed the wrong button and marked this as ready for review. Conflicts are not yet resolved.

@justin808
Copy link
Collaborator

@jrmhaig can you help us move to Github actions? #1193.

@justin808
Copy link
Collaborator

@ahangarha Please take this over and make a new PR. I'll close this issue when your PR is up.

@ahangarha
Copy link
Collaborator

May I know the objective of this PR? We already have migrated from travis to GitHub actions (#1198) and as far as I see, all tests pass. What issue is being addressed here? Are we still trying to use travis?

@jrmhaig
Copy link
Author

jrmhaig commented Nov 14, 2022

May I know the objective of this PR? We already have migrated from travis to GitHub actions (#1198) and as far as I see, all tests pass. What issue is being addressed here? Are we still trying to use travis?

I opened this ticket over a year ago, before you migrated to Github actions. I cannot remember exactly what I was doing but I may have been trying to update it for a newer version of Rails but got stopped because I couldn't get the tests to run. I think it was somehow tied up with the mimemagic issue from about that time.

If the tests have moved to Github actions and are now working then obviously this can be closed.

@ahangarha
Copy link
Collaborator

ahangarha commented Nov 18, 2022

@justin808 May you share your thoughts?

HardCarrier pushed a commit to HardCarrier/react-rails that referenced this pull request Jan 9, 2023
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running.

This update was first started in reactjs/react-rails#1114.
@Judahmeek Judahmeek closed this Jan 13, 2023
apple0820 added a commit to apple0820/react-rails that referenced this pull request Aug 15, 2023
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running.

This update was first started in reactjs/react-rails#1114.
Oleksandr0305 added a commit to Oleksandr0305/react-rails that referenced this pull request Feb 1, 2025
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running.

This update was first started in reactjs/react-rails#1114.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants