-
Notifications
You must be signed in to change notification settings - Fork 754
Get tests passing #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get tests passing #1114
Conversation
Main purpose is to update mimemagic as the version in the lock file was yanked from Rubygems.
d887a4b
to
74a3830
Compare
Chrome addon requires >= xenial
* Add Ruby 3.0 * Add Rails 5.2/Webpacker 5
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running. This update was first started in reactjs#1114.
@jrmhaig can you please resolve conflicts? We really need to switch to GH Actions. |
Sorry, I pressed the wrong button and marked this as ready for review. Conflicts are not yet resolved. |
@ahangarha Please take this over and make a new PR. I'll close this issue when your PR is up. |
May I know the objective of this PR? We already have migrated from travis to GitHub actions (#1198) and as far as I see, all tests pass. What issue is being addressed here? Are we still trying to use travis? |
I opened this ticket over a year ago, before you migrated to Github actions. I cannot remember exactly what I was doing but I may have been trying to update it for a newer version of Rails but got stopped because I couldn't get the tests to run. I think it was somehow tied up with the If the tests have moved to Github actions and are now working then obviously this can be closed. |
@justin808 May you share your thoughts? |
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running. This update was first started in reactjs/react-rails#1114.
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running. This update was first started in reactjs/react-rails#1114.
`mimemagic` removed version 0.3.3 (up through 0.3.6) and it was preventing the appraisal tests from running. This update was first started in reactjs/react-rails#1114.
Summary
WIP
Updating to get the tests working and updated for new versions of Ruby and Rails.
Other Information
mimemagic
inGemfile.lock
. The currently linked version was yanked.To do (help needed)
The tests are failing with the
rails_5.2_no_sprockets_webpacker_*
gemfiles:It look as though the way to start webpack has changed from
webpack-dev-server
towebpack server
but I don't understand the codebase enough to know what needs updating for this.For reference: webpack/webpack-dev-server#2759