-
-
Notifications
You must be signed in to change notification settings - Fork 23
Improve Caching Schema #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This now uses Should be performant enough to where we can put off #4 for a while. |
I had a concept to use cache versioning to help invalidate old web module files stored in cache. But, unfortunately this doesn't work since the temp directory names are randomized, thus we have no easily cross-platform replicable cache key. |
By default |
This reverts commit fe2dd92.
A note on changing |
Is the default behavior within Core to not override existing files, even if they have different contents? If not, then I think I should hold off on implementing anything related to cache invalidation until that takes place. |
The default behavior does not overwrite. The code there is a little messy though so I just put up a PR to clean that up: reactive-python/reactpy#586 |
Alright. I'll handle app directory stuff when reactive-python/reactpy#586 is closed and made into a PyPI release. In that case this PR is ready for merge. You need to make Python 3.7 tests non-required on your end for that to happen though. |
IDOM core can continue supporting 3.7, you'll just need to constrain the supported versions in |
@Archmonger the latest version of IDOM has been released with the changes from reactive-python/reactpy#586. Is there anything else to do here? |
This PR should be feature complete, can't be merged without making 3.7 not required. I'm assuming that's in the project settings? I'll make a separate PR to bump IDOM in here to the new version. |
Feel free to merge |
aiofile
for async file operations.../../../etc/passwd
)