Skip to content

Rename cache backend to "idom" #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename cache backend to "idom" #47

wants to merge 1 commit into from

Conversation

Archmonger
Copy link
Contributor

fix #46

@Archmonger Archmonger requested a review from a team as a code owner January 12, 2022 08:40
rmorshea
rmorshea reviewed Jan 12, 2022
View reviewed changes
src/django_idom/config.py
@@ -15,7 +15,7 @@
_CACHES = getattr(settings, "CACHES", {})
if _CACHES:
if "idom_web_modules" in getattr(settings, "CACHES", {}):
IDOM_WEB_MODULE_CACHE = "idom_web_modules"
IDOM_WEB_MODULE_CACHE = "idom"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename IDOM_WEB_MODULE_CACHE to IDOM_CACHE as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I already handled this in PR #50 so I'm going to close this PR.

@Archmonger Archmonger closed this Jan 12, 2022
@Archmonger Archmonger deleted the rename-cache-backend branch July 3, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename cache backend to "idom"
2 participants
@Archmonger @rmorshea