Skip to content

Add SLF4J #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Add SLF4J #180

merged 1 commit into from
Aug 26, 2016

Conversation

acogoluegnes
Copy link
Contributor

Fixes #114

@acogoluegnes
Copy link
Contributor Author

We now have a bunch a stack traces bubbling up during the test suite, because some errors were not logged at all in the exception handler. They should be harmless, as they occur during tests of error scenario. Let's see after a few builds if we should remove them, to make the CI reports easier to read.

@michaelklishin michaelklishin self-assigned this Aug 26, 2016
@michaelklishin
Copy link
Contributor

@acogoluegnes this can be handled separately but I think java.net.SocketExceptions with reason "Socket closed" and even "Connection reset" should be logged as warnings: they are just a fact of life in any production system. Logging them as errors will scare too many users for no good reason.

So logging them as warnings and maybe without full stack trace would be sufficient. Feel free to look into it in a follow-up PR.

@michaelklishin michaelklishin merged commit bac5a3f into master Aug 26, 2016
@acogoluegnes acogoluegnes deleted the rabbitmq-java-client-114 branch March 21, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants