Skip to content

Logging library integration #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelklishin opened this issue Dec 10, 2015 · 3 comments
Closed

Logging library integration #114

michaelklishin opened this issue Dec 10, 2015 · 3 comments
Assignees
Milestone

Comments

@michaelklishin
Copy link
Contributor

Over the years the library has been 0-dependency but issues such as #113 and calls to introduce Metrics integration are pretty common now.

This issue is only about logging. Should we use SLF4J? Or some kind of handlers for apps to hook into (was discussed for .NET client, for example). It remains to be discussed and decided.

@michaelklishin
Copy link
Contributor Author

I think we should address this after #37, because managing dependencies with Ant is nowhere near as straightforward as with Gradle.

@xuwei-k
Copy link
Contributor

xuwei-k commented Jun 9, 2016

+1 use slf4j

@michaelklishin
Copy link
Contributor Author

OK, SLF4J it is then. We are convinced it's a much better idea to have logging compared to having 0 dependencies (the same goes for metrics).

@michaelklishin michaelklishin added this to the 4.0.0 milestone Aug 24, 2016
acogoluegnes added a commit that referenced this issue Aug 26, 2016
@acogoluegnes acogoluegnes mentioned this issue Aug 26, 2016
stream-iori pushed a commit to stream-iori/rabbitmq-java-client that referenced this issue Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants