Fix Fedora rawhide builders #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozencemetery
force-pushed
the
fedora_gpg
branch
2 times, most recently
from
5f51be3 to
b39fa50
Compare
|
seems reasonable-ish. Would prefer to have GPG checks, but if they break when fedora branches, I'm not sure there's much we can do about it... |
DirectXMan12
approved these changes
Sep 5, 2017
|
Agreed... it's probably not something we want in our release builds if we can avoid it, but on the other hand, release builds aren't working right now and haven't been for a while. |
frozencemetery
force-pushed
the
fedora_gpg
branch
from
fc88cd4 to
a719d3e
Compare
|
@DirectXMan12 Please review added commit. Thanks! |
frozencemetery
changed the title
|
can you put the RFC number after |
|
(also possibly add a more elaborate comment than |
frozencemetery
force-pushed
the
fedora_gpg
branch
from
a719d3e to
9ad0ad1
Compare
|
Added version to commit and clarified language. Elaborated on comment inline. |
krb5 >= 1.14 adds the clockskew to the server context lifetime. Allow this behavior in test_high_level.py.
DirectXMan12
approved these changes
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to happen roughly every time it branches; see build log for #124.