Implement support for GSSAPI extension RFC 5801 #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DirectXMan12 / @frozencemetery Would you like specific tests on this one as well? They'd again have to be implementation-specific, as the RFC doesn't specify OID<->SASL Name mappings and/or mech names/descriptions. |
cipherboy
force-pushed
the
rfc5801
branch
2 times, most recently
from
07f4fa3 to
4086dae
Compare
|
I don't particularly want implementation-specific tests, but will let @DirectXMan12 decide that. |
DirectXMan12
suggested changes
Aug 10, 2017
gssapi/raw/ext_rfc5801.pyx
Outdated
| gss_OID *mech_type) nogil | ||
|
|
||
|
|
||
| def inquire_saslname_for_mech(OID mech): |
There was a problem hiding this comment.
RFC 5801 doesn't mark mech as optional, so this should be marked not None -- it shouldn't be an option to pass no mech.
|
Updated. Thanks @DirectXMan12! :) |
DirectXMan12
suggested changes
Sep 5, 2017
|
|
||
| Returns: | ||
| InquireSASLNameResult: the results of inquiry; a mech's SASL name, | ||
| name, and description. |
| sasl_name (bytes): SASL name of the mechanism | ||
|
|
||
| Returns: | ||
| OID: the mechanism with corresponding SASL name. |
gssapi/raw/ext_rfc5801.pyx
Outdated
| cdef gss_buffer_desc mech_desc | ||
| cdef gss_OID m = GSS_C_NO_OID | ||
|
|
||
| if mech is not None: |
There was a problem hiding this comment.
no need for this, because you have the not None clause above.
gssapi/raw/ext_rfc5801.pyx
Outdated
| raise GSSError(maj_stat, min_stat) | ||
|
|
||
|
|
||
| def inquire_mech_for_saslname(bytes sasl_name): |
There was a problem hiding this comment.
this should also be not None, presumably.
DirectXMan12
approved these changes
Sep 5, 2017
|
Will merge once we get Travis working |
frozencemetery
force-pushed
the
rfc5801
branch
from
dab96c7 to
d64b9a2
Compare
RFC 5801 provides SASL-specific mechanism inquiry calls for GSSAPI. The inquire_mech_for_saslname call allows resolving mechs by their respective SASL names, and inquire_saslname_for_mech allows the reverse operation, also providing a mechanism name and description. These calls are implemented as part of the raw interface. Signed-off-by: Alexander Scheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 5801 provides SASL-specific mechanism inquiry
calls for GSSAPI. The inquire_mech_for_saslname
call allows resolving mechs by their respective
SASL names, and inquire_saslname_for_mech allows
the reverse operation, also providing a mechanism
name and description. These calls are implemented
as part of the raw interface.