Robust plot schema lookups #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naive direct lookups do not account for various exceptions and edge cases
we present users with "area" as "scatter + fill"
|
The next PR will introduce the |
This component API uses information about which gd container it targets to further specify handlers and data passed down to lower level components
We may need to use an array but it will involve complexity when working with generic updates from Layout. Remove for now until we know we need it.
<Trace> mixed logic with structure. We aim to present a structural component API for declaring the structure of the UI. This should be independent of the logical connections to Plotly.js. Now we can pair connectTraceToPlot with <Fold> or <Section> or even <Panel>
This more closely approximates the way different layers must be linked together.
The Layout component is now whatever connectToLayout(<Container>) is necessary
bpostlethwaite
changed the title
| // scatter with fill as an "area" chart type for convenience. | ||
| const traceTypes = Object.keys(context.plotSchema.traces).filter( | ||
| t => t !== 'area' | ||
| ); |
There was a problem hiding this comment.
hopefully not for long 🙏
Sub menus and Colorpicker
Centering of fields with no labels
…cess Default fonts and correct plot schema access
<Field> component and Reorganize folder structure
Introduce layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexcjohnson
cc @VeraZab
Based of TestSectionVisibility PR this PR adds more robust handling of
plotSchemaattrs.