-
-
Notifications
You must be signed in to change notification settings - Fork 112
Default fonts and correct plot schema access #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bpostlethwaite
merged 23 commits into
reorganizeFolderStructure
from
DefaultFontsAndCorrectPlotSchemaAccess
Nov 13, 2017
Merged
Default fonts and correct plot schema access #52
bpostlethwaite
merged 23 commits into
reorganizeFolderStructure
from
DefaultFontsAndCorrectPlotSchemaAccess
Nov 13, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Love it. As we've discussed before we may need separate UI bounds and hard bounds for certain items, but we can address that later on as it'll need to be a plotly.js addition. |
Sub menus and Colorpicker
Centering of fields with no labels
This was referenced Nov 15, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #51
Add a few default fonts with fallbacks that should cover MacOS, iOS, Windows and Android (sorry Linux...).
Actually get around to testing and using the PlotSchema accessors. Turns out I had forgotten to pass in
parts
. That behaviour is corrected and tested.Use the accessors to automatically lookup min and max values for Numeric and other widgets.