Extensions for ContainerInterface|Controller::has() #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookyman
changed the title
lookyman
force-pushed
the
type-specifying-extensions
branch
2 times, most recently
from
9de4f92 to
843196c
Compare
lookyman
force-pushed
the
type-specifying-extensions
branch
from
664b6ba to
4d3f508
Compare
lookyman
force-pushed
the
type-specifying-extensions
branch
from
4d3f508 to
7857d54
Compare
alcaeus
reviewed
Jul 30, 2018
|
|
||
| public function getClass(): string | ||
| { | ||
| return 'Symfony\Component\DependencyInjection\ContainerInterface'; |
There was a problem hiding this comment.
This should use the ::class constant instead of a string classname.
There was a problem hiding this comment.
There is a reason for a simple string here, trust me. 😊
There was a problem hiding this comment.
Genuinely curious, why so?
There was a problem hiding this comment.
To keep Composer Requirement Checker shut up. And we keep it shut up because we don't want to have symfony packages in require.
There was a problem hiding this comment.
Ah, I didn't know Composer Requirement Checker complains about those as well. Thanks for letting me know! 👍
|
|
||
| public function getClass(): string | ||
| { | ||
| return 'Symfony\Bundle\FrameworkBundle\Controller\Controller'; |
There was a problem hiding this comment.
This should use the ::class constant instead of a string classname.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.