Skip to content

Conditional $container->get() not evaluated correctly #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alcaeus opened this issue Jul 27, 2018 · 5 comments
Closed

Conditional $container->get() not evaluated correctly #6

alcaeus opened this issue Jul 27, 2018 · 5 comments

Comments

@alcaeus
Copy link
Contributor

alcaeus commented Jul 27, 2018

First off, is there a way to test the Symfony extension in the PHPStan Playground? In absence of that, here is the classic way of explaining the problem. We have a couple of conditional get calls to the service container like so:

if ($container->has('doctrine.orm.entity_manager')) {
    $em = $container->get('doctrine.orm.entity_manager');
    // ...
}

Unfortunately, this conditional is not properly evaluated:

Service "doctrine.orm.entity_manager" is not registered in the container.

In this case, the get should not cause an error since it will not be reached if there's no such service.

@lookyman
Copy link
Collaborator

You are correct, this is not currently supported at all. I will give it some thought over the weekend and hopefully I can come up with a solution.

@alcaeus
Copy link
Contributor Author

alcaeus commented Jul 27, 2018

Great, thank you for the quick feedback! ❤️

@lookyman
Copy link
Collaborator

@alcaeus I've tried several approaches, all of them being rather hacky, and I don't particularly like any of them, but this one should work #7. Could you please test it?

@lookyman
Copy link
Collaborator

Closed by #7

@github-actions
Copy link

github-actions bot commented May 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants