Implement Categorical.searchsorted(v, side, sorter) #8420 #8972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.assert_numpy_array_equal(res, chk) | ||
|
|
||
| # Scalar version of single item array | ||
| # Ambiguous what Categorical should return as np.array returns |
There was a problem hiding this comment.
I am happy with this always returning an array. Returning a scalar indexer is a bit odd IMHO. Pls fixup and just have one path.
… requested array output
|
looks good. just need a release note, enhancements section. ping when you have pushed. thanks. |
|
can you add a release note? |
|
Added in whatsnew for 0.15.2 |
|
merged via 5928075 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8420
Continuation of #8928