Revert "REGR: concat(ints, bools) casting to object #42092" #42553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andas-dev#42541)" This reverts commit 80a72c1.
|
The solution is to fix it for ArrayManager |
|
This is just temporary, so we can get green, while the ArrayManger case is fixed. If the ArrayManager fix is simple, we can always close this and merge that instead. Otherwise, we should probably merge this after a couple of days so that CI remains green, and re-land #42541 |
|
ok why don't we wait a day or 2 to see if can fix ArrayManager here. |
|
I think this just needs a change in |
|
Gonna close since I think an actual fix has been sent in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #42541
This fails ArrayManager.
cc @jbrockmendel