REGR: concat(ints, bools) casting to object #42092 #42541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jul 14, 2021
jbrockmendel
commented
- closes REGR: 1.3.0rc behavior change with concatenating boolean and numeric columns #42092
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
added
Dtype Conversions
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jul 15, 2021
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Jul 15, 2021
#42548) Co-authored-by: jbrockmendel <[email protected]>
|
@jreback @jbrockmendel I think this pull request added a test( Can this be reverted? |
lithomas1
added a commit
to lithomas1/pandas
that referenced
this pull request
Jul 15, 2021
…andas-dev#42541)" This reverts commit 80a72c1.
jreback
reviewed
Jul 19, 2021
| @@ -23,7 +23,7 @@ Fixed regressions | |||
| - Performance regression in :meth:`DataFrame.to_dict` and :meth:`Series.to_dict` when ``orient`` argument one of "records", "dict", or "split" (:issue:`42352`) | |||
| - Fixed regression in indexing with a ``list`` subclass incorrectly raising ``TypeError`` (:issue:`42433`, :issue:`42461`) | |||
| - Fixed regression in :meth:`DataFrame.isin` and :meth:`Series.isin` raising ``TypeError`` with nullable data containing at least one missing value (:issue:`42405`) | |||
| - | |||
| - Regression in :func:`concat` between objects with bool dtype and integer dtype casting to object instead of to integer (:issue:`42092`) | |||
There was a problem hiding this comment.
@jbrockmendel in theory we should the AM PR as an additional PR here
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.