-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[bn] Translate Landing Page for Bengali localization kickoff #6775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Debjoty Mitra <[email protected]>
Signed-off-by: Debjoty Mitra <[email protected]>
The translation looks accurate and is aligned with the original content. |
@chalin I don't think there is any issue with spelling. Some words might appear unfamiliar because technical terms have been written directly in Bangla, which I believe is completely normal. This approach is also used in the CNCF glossary and k8s Bengali docs. However, the system is also flagging commonly known Bangla words as unknown. Additionally, I’d appreciate some clarification regarding the file format. |
Translation looks good. |
To satisfy the spell checker we also need to add the language to https://github.com/open-telemetry/opentelemetry.io/blob/main/.cspell.yml, and do some other infrastructure changes. We (@open-telemetry/docs-maintainers) can manage that. Don't worry about the CI checks right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debjotyms Thanks so much for your contribution—really appreciate your effort on this!
I’ve suggested a few minor changes. One small note: if we preserve the original English line breaks, it will help a lot when updating or syncing the Bengali localization with the source content. For example:
- High-quality, ubiquitous, and portable telemetry to enable effective
- observability
+ কার্যকর অবজারভেবিলিটির জন্য উচ্চ-মানের, সর্বজনীন ও পোর্টেবল টেলিমেট্রি প্রদান
Maintaining a similar line structure like this makes future maintenance easier:
+ কার্যকর অবজারভেবিলিটির জন্য উচ্চ-মানের, সর্বজনীন ও পোর্টেবল
+ টেলিমেট্রি প্রদান
It looks like the file has been localized under the wrong directory.
The correct directory should be in content/bn/
instead of content/en/
as discussed here.
Signed-off-by: Debjoty Mitra <[email protected]>
Thank you so much @sajibAdhi for the review and helpful suggestions! I've applied the fixes, including moving the file to the correct directory and adjusting the line breaks as discussed. It should be all set now. Please have a look when you get a chance. Let me know if there’s anything else to improve! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
This PR translates the Landing Page (
content/en/_index.md
) into Bengali (bn) as part of the initial localization effortFixes: #6765
Please let me know if any further adjustments are needed.