Skip to content

Remove non Python3 compatible files #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2016

Conversation

lesteve
Copy link
Contributor

@lesteve lesteve commented Nov 4, 2016

Quoting @pv in #70:

I believe these file are not widely used, so porting them to Python 3 may not be worthwhile. I don't think deleting them will cause a large inconvenience for anyone.

Fixes #70.
Closes #8. Closes #35.

@lesteve lesteve force-pushed the remove-non-python3-compatible-files branch from a2b8201 to ad672f1 Compare November 4, 2016 14:07
@lesteve
Copy link
Contributor Author

lesteve commented Nov 4, 2016

I quickly looked for numpydoc traitsdoc via the github web UI and could not find any usage outside that was not test_traitsdoc.py. Same thing for plot_directive. I am happy to search more systematically via the github API if that's deemed necessary.

@stefanv
Copy link
Contributor

stefanv commented Nov 4, 2016

/cc @rkern @cournape

@rkern
Copy link
Member

rkern commented Nov 4, 2016

I think all uses of traitsdoc have been vendorized, so it is not necessary to distribute it with numpydoc.

@stefanv
Copy link
Contributor

stefanv commented Nov 5, 2016

Thanks, Robert. Merging.

@stefanv stefanv merged commit 5084f79 into numpy:master Nov 5, 2016
jnothman added a commit to jnothman/numpydoc that referenced this pull request Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants