Skip to content

Some files are not compatible with Python 3 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lesteve opened this issue Nov 4, 2016 · 3 comments
Closed

Some files are not compatible with Python 3 #70

lesteve opened this issue Nov 4, 2016 · 3 comments

Comments

@lesteve
Copy link
Contributor

lesteve commented Nov 4, 2016

In our case the numpydoc functionality does not seem to be affected as these files don't seem to be used.

Super hacky one-liner to get the full list of problematic files:

for i in numpydoc/*.py; do ipython -c "import `echo ${i/.py/} | sed -e 's@/@.@'`" | grep Traceback > /dev/null || echo $i; done

Output:

numpydoc/comment_eater.py
numpydoc/compiler_unparse.py
numpydoc/phantom_import.py
numpydoc/plot_directive.py
numpydoc/traitsdoc.py

Most of the files are 4 years old but traitsdoc.py which is 2 years old. Are they still being used/maintained?

One I am particularly surprised by is plot_directive.py, is it really needed and how is it different from the matplotlib one?

@pv
Copy link
Member

pv commented Nov 4, 2016 via email

@lesteve
Copy link
Contributor Author

lesteve commented Nov 4, 2016

In our case (joblib) this is mildly annoying because we bundle numpydoc and if you are not careful enough nosetests with its automatic disovery of tests, tries to import the numpydoc modules and fails under Python 3.

Would there be any interest in PRs making them Python 3 compatible? Any idea whether their functionalities are actually being used?

What about a PR removing plot_directive.py if the functionality has been merged in matplotlib a while ago?

@pv
Copy link
Member

pv commented Nov 4, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants