-
Notifications
You must be signed in to change notification settings - Fork 532
ENH: Add workbench.CiftiSmooth interface #2871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2871 +/- ##
==========================================
- Coverage 67.49% 64.13% -3.37%
==========================================
Files 342 341 -1
Lines 43562 43537 -25
Branches 5422 5419 -3
==========================================
- Hits 29402 27922 -1480
- Misses 13458 14543 +1085
- Partials 702 1072 +370
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have a question about the position
metadata for flagged arguments.
desc="Specify the left surface to use") | ||
left_corrected_areas = File( | ||
exists=True, | ||
position=6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all these flagged arguments truly positional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think not, but was staying true to how it appears to be written up
https://github.com/Washington-University/workbench/blob/683ce2e9658ad55a926f0dda947d4537c0360d78/src/Algorithms/AlgorithmCiftiSmoothing.cxx#L54
1.1.9 (February 25, 2019) Full changelog: https://github.com/nipy/nipype/milestone/30?closed=1 * FIX: Make positional arguments to LaplacianThickness require previous argument (nipy#2848) * FIX: Import math and csv modules for bids_gen_info (nipy#2881) * FIX: Ensure outputs can be listed in camino.ProcStreamlines by defining instance variable (nipy#2739) * ENH: Allow afni.MaskTool to take multiple input files (nipy#2892) * ENH: Add flags dictionary input to spm.Level1Design (nipy#2861) * ENH: Threshold stddev once only in TSNR (nipy#2883) * ENH: Add workbench.CiftiSmooth interface (nipy#2871) * DOC: Replace initialism typo in comment with intended phrase (nipy#2875) * DOC: Fix typos in ANTs Registration input documentation (nipy#2869) * tag '1.1.9': (34 commits) MNT: Update changelog MNT: Add Katherine Bottenhorn, Paul Mihai to Zenodo MNT: Add kchawla-pi to Zenodo, update mailmap and ordering add to zenodo MNT: Update zenodo ordering Update .zenodo.json afni utils.py - masktool - InputMultiPath for in_file argument MNT: Update .zenodo ordering MNT: Add Oliver Contier name to .zenodo.json Update nipype/interfaces/spm/model.py ENH: Add zenodo updating script MNT: Update mailmap to avoid renames in script MNT: Update .mailmap, .zenodo.json MNT: Version 1.1.9 DOC: 1.1.9 changelog ENH: minor - compute non degenerate stddev map once BF: regenerated test_auto_LaplacianThickness using wonderfully long running tools/checkspecs.py TEST: Thorough test of LaplacianThickness requirement cascade FIX: Requires error text was backwards import math and csv modules for bids_gen_info ...
List of changes proposed in this PR (pull-request)
-cifti-smoothing
command fromwb_command
Acknowledgment