fix sse endpoint path preservation #504
Merged
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jerome3o-anthropic
approved these changes
May 16, 2025
| @@ -147,13 +147,7 @@ export class SSEClientTransport implements Transport { | |||
| this._endpoint = new URL(messageEvent.data, this._url); | |||
|
|
|||
| // If the original URL had a custom path, preserve it in the endpoint URL | |||
| const originalPath = this._url.pathname; | |||
There was a problem hiding this comment.
I think this still might be incorrect, in the sense that the server can advertise any URI and expect the client to send POST messages there:
When a client connects, the server MUST send an endpoint event containing a URI for the client to use for sending messages. All subsequent client messages MUST be sent as HTTP POST requests to this endpoint.
I think the problem in modelcontextprotocol/inspector#313 et al is upstream of the client – specifically, the client should not be able to control the endpoint, but there's something in the inspector that's ignoring the correct endpoint (or the server transport is sending an incorrect endpoint value.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the fix in #466, which was arbitrarily converting an "sse" endpoint suffix to a "messages" endpoint suffix.
Motivation and Context
bugfix
How Has This Been Tested?
updated erroneous existing test
Breaking Changes
no
Types of changes
Checklist
Additional context