fix: preserve custom paths in SSE endpoint URLs #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we include those filing tests in this PR |
When an SSE client connects with a custom path (e.g., /api/v1/custom/sse), ensure the endpoint URL maintains the same base path structure but with /messages instead of /sse. This fixes issues where custom endpoints were getting collapsed to the root path. Should fix issues reported in modelcontextprotocol/inspector#313 and #296 Tests demonstrating the issue were added in PR #439 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
bhosmer-ant
force-pushed
the
fix/sse-custom-endpoint-paths
branch
from
39629e2 to
2f522bf
Compare
|
@ihrpr brought the tests over - note, dropped the change to package-lock.json |
|
@ihrpr do you have a plan for this release? |
3 tasks
|
As a heads up, this breaks SSE integrations with mcp.run – we were sending the full SSE endpoint down to support the python-sdk and now the endpoint pathname is being rewritten to |
8 tasks
@chrisdickinson thanks for catching - #504 should fix, though it couldn't hurt to verify [edit: not that simple, reverted path preservation and will revisit] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When an SSE client connects with a custom path (e.g.,
/api/v1/custom/sse), ensure the endpoint URL maintains the same base path structure but with/messagesinstead of/sse. This fixes issues where custom endpoints were getting collapsed to the root path.Problem
The SSE client was not preserving custom paths when constructing endpoint URLs. When a client connected to a server at a custom path like
/api/v1/custom/sse, the endpoint URL would be constructed without preserving the custom path, resulting in POST requests being sent to/messagesinstead of/api/v1/custom/messages.Solution
Modified the endpoint event handler in the SSE client to:
/ssesuffix)/messagessuffixTesting
This PR makes the failing tests from #439 pass. The tests verify that:
Related Issues
Test Plan
🤖 Generated with Claude Code