chore: remove JS code generated from protos #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamaljsr
force-pushed
the
proto-cleanup
branch
3 times, most recently
from
2abd118 to
67c9acb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS/TS code generated by
protocfrom the*.protofiles do not need to be stored in the repo. They can be generated after cloning locally. This PR removes the generated files and updates thebuild-protos.shscript to fix a small typing error.To test:
/app/src/types/generated/dircd app; yarn protosto generate the JS/TS files/app/src/types/generated/yarn lint; yarn tsc; yarn test:ci