Skip to content

Improve our usage of GRPC proto files #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamaljsr opened this issue Apr 27, 2020 · 0 comments · Fixed by #81
Closed

Improve our usage of GRPC proto files #20

jamaljsr opened this issue Apr 27, 2020 · 0 comments · Fixed by #81

Comments

@jamaljsr
Copy link
Member

The app currently requires proto to be pre-compiled. This compilation process generates TS/JS code that is not valid and needs some tweaking. I currently do this manually, but it should be automated.

Changes:

  • add var proto = { lnrpc: {} }; to the top of lnd_pb.js
  • add var proto = { looprpc: {} }; to the top of loop_pb.js
  • add var proto = { google: { api: {} } }; to the top of annotation_pb.js
  • add var proto = { google: { api: {} } }; to the top of http_pb.js

Alternatively, I would like to do some further research into protobufjs to see if our usage of proto files can be improved even further.

@jamaljsr jamaljsr linked a pull request Jul 25, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant