Skip to content

Drag'n'Drop with mouse events #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 26, 2022
Merged

Drag'n'Drop with mouse events #322

merged 13 commits into from
Mar 26, 2022

Conversation

AntonBurchak
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Feb 23, 2022
Open
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AntonBurchak
❌ Anton_Burchak

Anton_Burchak seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@AntonBurchak
Copy link
Contributor Author

@tarasyyyk Можеш будь-ласка подивитись?)

@dolgachio
Copy link
Collaborator

@AntonBurchak привіт, для комітів у цьому пулл реквесті ви використала два різні аккаунти:
✅ AntonBurchak
❌ Anton_Burchak
Для того, щоб ми могли прийняти пулл реквест, потрібно додати другого користувача до вашого GitHub аккаунту

@dolgachio dolgachio added the in progress Translation in progress label Mar 13, 2022
@dolgachio dolgachio self-requested a review March 13, 2022 22:23
dolgachio
dolgachio requested changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@dolgachio dolgachio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую за чудовий переклад! Будя ласка, подивіться на мої коментарі.
Звертаю вашу увагу, що я ще не закінчиві переверку, завершу сьогодні ;)

2-ui/3-event-details/4-mouse-drag-and-drop/2-drag-heroes/source.view/index.html Outdated

<p>And one more thing: heroes may never leave the page. If they reach the edge of the document, no dragging outside of it.</p>

<h2>Розставте супергероїв по полю.</h2>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Будь ласка, змініть цей файл, відповідно до моїх коменьтарів вище

@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

dolgachio
dolgachio requested changes Mar 21, 2022
View reviewed changes
@javascript-translate-bot
Copy link
Contributor

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@dolgachio dolgachio removed partially reviewed in progress Translation in progress labels Mar 21, 2022
@AntonBurchak AntonBurchak requested a review from dolgachio March 22, 2022 20:30
@AntonBurchak
Copy link
Contributor Author

@stas-dolgachov Дякую за ретельне ревью. Я вніс корективи до перекладу, будь-ласка перевірте

@AntonBurchak
Copy link
Contributor Author

/done

@dolgachio
Copy link
Collaborator

Дякую за чудовий переклад!

@dolgachio dolgachio merged commit 8a8d92e into javascript-tutorial:master Mar 26, 2022
@javascript-translate-bot
Copy link
Contributor

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolgachio dolgachio dolgachio approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonBurchak @CLAassistant @dolgachio @javascript-translate-bot