Skip to content

/commits Author can link to git's https://gitea.com/<name>, instead of https://gitea.com/<username> #34418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brian6932 opened this issue May 9, 2025 · 3 comments · Fixed by #34423
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone

Comments

@brian6932
Copy link

brian6932 commented May 9, 2025

Description

This doesn't seem to happen when noreply emails are used.
When a different git name's used from the account's username, the Author link, username, and pfp in /commits, link to the wrong gitea account. When you click on the commit sha, and view the commit directly, it links correctly as expected, this only seem so happen for non-noreply emails, this doesn't happen on GitHub and GitLab. The git name's expected, but the link to the username, and pfp aren't.

Gitea Version

1.23.7

Can you reproduce the bug on the Gitea demo site?

Used official site.

Log Gist

No response

Screenshots

https://gitea.com/brian6932/test/commits/branch/main

https://gitea.com/brian6932/test/commit/d84094141b494671a030136b747f847b67a23f22 works as expected.

Git Version

Not my server.

Operating System

Not my server.

How are you running Gitea?

Using https://gitea.com/.

Database

None

@techknowlogick techknowlogick added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 9, 2025
@wxiaoguang
Copy link
Contributor

Related to Commit Signatures Displayed in Red in Commit History UI After Upgrading to Gitea 1.24.0-rc0 #34353

-> #34353 (comment)

@lunny

@wxiaoguang
Copy link
Contributor

-> Fix GetUsersByEmails #34423

lunny pushed a commit that referenced this issue May 10, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 10, 2025
@lunny lunny modified the milestones: 1.24.0, 1.23.8 May 10, 2025
wxiaoguang added a commit that referenced this issue May 10, 2025
Backport #34423 by wxiaoguang

Fix #34418, fix #34353

Co-authored-by: wxiaoguang <[email protected]>
@wxiaoguang
Copy link
Contributor

1.24 nightly is ready and contains the fix (it will be 1.24.0 soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants