Skip to content

Commit Signatures Displayed in Red in Commit History UI After Upgrading to Gitea 1.24.0-rc0 #34353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eli-yip opened this issue May 3, 2025 · 3 comments · Fixed by #34423
Closed
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone

Comments

@eli-yip
Copy link

eli-yip commented May 3, 2025

Description

After upgrading to Gitea 1.24.0-rc0, the commit signatures in the commit history interface are displayed in red, while they appear normal in the repository homepage and commit details.

I guess it's related to username detection on commit history interface. As I can't go to profile page by clicking avatar/username displayed on commit history.

Screenshots

repo homepage:

Image

commit history:

Image

wrong nickname for username on commit history page: It should have a avatar as others. And more, clicking on it will jump to user profile with nickname in uri path instead of username, which is not expected.

Image

commit details:

Image

Gitea Version

1.24.0-rc0

Can you reproduce the bug on the Gitea demo site?

No

Operating System

MacOS 15.4.1

Browser Version

Chromium: 136.0.7103.60

@eli-yip eli-yip added topic/ui Change the appearance of the Gitea UI type/bug labels May 3, 2025
@wxiaoguang
Copy link
Contributor

I guess it's related to username detection on commit history interface. As I can't go to profile page by clicking avatar/username displayed on commit history.

I also think it is the root problem. It is also reproducible on gitea.com , maybe related to some changes to the user loading. @lunny

For example: https://gitea.com/gitea/act_runner/commits/branch/main

Image

https://gitea.com/gitea/act_runner/commit/b1ae30dda8292b255ba8e6d230817e4ca949090d

Image

@wxiaoguang
Copy link
Contributor

Maybe this will fix: -> Fix GetUsersByEmails #34423

@lunny lunny closed this as completed in 9b8609e May 10, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue May 10, 2025
wxiaoguang added a commit that referenced this issue May 10, 2025
Backport #34423 by wxiaoguang

Fix #34418, fix #34353

Co-authored-by: wxiaoguang <[email protected]>
@wxiaoguang
Copy link
Contributor

1.24 nightly is ready and contains the fix (it will be 1.24.0 soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants