Refactor raven-js to use CommonJS modules, class instances (2.x) #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts raven-js to use CommonJS modules, internally. Distributables are built with Browserify.
(Same as #421, but made against the 2.x branch.)
Public API changes
Internal changes
A lot of internal changes that shouldn't affect users. Most notably, Raven itself is now a class instance, and most previously-private variables and functions are accessible as "private" object properties (e.g.
Raven._globalOptions
andRaven._handleStackInfo
). They're aliased with an underscore for a reason – you shouldn't access these or assume anything about them.This also means that Raven's API methods must be called with
Raven
as thethis
value. This could impact users if they have been aliasingRaven
API functions directly, and not invoked them on theRaven
object itself.e.g.
Hopefully nobody does this.