-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Refactor raven-js to use CommonJS modules, class instances [WIP] #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
|
||
module.exports = { | ||
isUndefined: isUndefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol tabs
Hmm, so now that I see So, beginning to wonder if this is a good idea or not (class instances). |
Changes:
Raven
is now a class; can be initialized asnew Raven()
(only via CommonJS)src
Raven
singleton (API hasn't changed)isError
) into src/utils.jsStill WIP:
Thoughts:
This is a huge set of changes. It makes Raven more "OO" – which I'm sure will spur some debate. But the result is that there is no longer bunch of global variables whose state is mysteriously mutated between raven.js / raven.test.js, and tests (IMHO) are much easier to follow.