Skip to content

feat: Set required node version to >=14.18.0 for all packages #10968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

feat: Set required node version to >=14.18.0 for all packages #10968

merged 2 commits into from
Mar 7, 2024

Conversation

AbhiPrasad
Copy link
Member

we would like to start using node protocol imports in the SDK to unblock #10960 and #10928

This requires us to have a minimum supported Node version of 14.18.0 as per https://2ality.com/2021/12/node-protocol-imports.html

@AbhiPrasad AbhiPrasad requested review from timfish and mydea March 7, 2024 17:40
@AbhiPrasad AbhiPrasad added this to the 8.0.0 milestone Mar 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.5 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.75 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.65 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.3 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.98 KB (-0.18% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.98 KB (-0.18% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.36 KB (-0.01% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.36 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped) 22.56 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - CDN Bundle (gzipped) 75.59 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (gzipped) 67.19 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - CDN Bundle (gzipped) 33.05 KB (-0.1% 🔽)
@sentry/browser - CDN Bundle (gzipped) 24.01 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (minified & uncompressed) 210.89 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - CDN Bundle (minified & uncompressed) 99.69 KB (-0.13% 🔽)
@sentry/browser - CDN Bundle (minified & uncompressed) 71.74 KB (-0.02% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.99 KB (-0.08% 🔽)
@sentry/react - Webpack (gzipped) 22.6 KB (-0.02% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.47 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.87 KB (-0.07% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.41 KB (-0.02% 🔽)

timfish
timfish approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity this makes the minimum supported Electron version v15

@AbhiPrasad AbhiPrasad merged commit fa19ce0 into develop Mar 7, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-bump-to-node-14.18 branch March 7, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @timfish @mydea