feat(astro): Update @sentry/astro to use OpenTelemetry
#10960
Conversation
size-limit report 📦
|
|
Update: while tests pass here, I could not get this to really run in a local test app. 16:18:36 [ERROR] [vite] x Build failed in 512ms
[commonjs--resolver] Failed to resolve entry for package "https". The package may have incorrect main/module/exports specified in its package.json.So that's one thing. |
I'm looking to add that once #10928 is merged since it adds to the package exports that get added there |
|
Update: importing https from |
| @@ -1,5 +1,5 @@ | |||
| import type { ClientRequest, IncomingHttpHeaders, RequestOptions as HTTPRequestOptions } from 'http'; | |||
| import type { RequestOptions as HTTPSRequestOptions } from 'https'; | |||
| import type { ClientRequest, IncomingHttpHeaders, RequestOptions as HTTPRequestOptions } from 'node:http'; | |||
There was a problem hiding this comment.
These ones shouldn't matter since they're type imports and wont end up in the output
we would like to start using node protocol imports in the SDK to unblock #10960 and #10928 This requires us to have a minimum supported Node version of `14.18.0` as per https://2ality.com/2021/12/node-protocol-imports.html
|
I know auto-instrumentation is broken with this but a) I need this to start experimenting with other PRs + we can test out more ESM stuff hence I'm going to go ahead and merge this. |
Let's see how this goes, as a first meta SDK using OTEL under the hood! 🤞
For now I decided to remove the Prisma integration in Astro as that leads to weird build issues etc....