Skip to content

[v8] Refactor usages of span.startChild() to startInactiveSpan() #10900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mydea opened this issue Mar 4, 2024 · 0 comments
Closed

[v8] Refactor usages of span.startChild() to startInactiveSpan() #10900

mydea opened this issue Mar 4, 2024 · 0 comments

Comments

@mydea
Copy link
Member

mydea commented Mar 4, 2024 •
edited by AbhiPrasad
Loading

We have some leftover usages of span.startChild(). Some of them are related to #10898, but others are standalone and should be refactored to just create a span based on the active span.

In most cases, we can probably refactor them to just use startInactiveSpan instead, unless we need the span to be active (which is rarely the case, as far as I could see).

I would ignore the usage in old node for now, we can remove this eventually.

### Tasks
- [ ] https://github.com/getsentry/sentry-javascript/pull/10956
- [ ] https://github.com/getsentry/sentry-javascript/pull/10943
- [x] MAYBE: Refactor `startChild` usage in node & node performance integrations - probably safe to ignore this for now
@mydea mydea changed the title [v8] Refactor usages of span.startChild [v8] Refactor usages of span.startChild() to startInactiveSpan() Mar 4, 2024
This was referenced Mar 4, 2024
Closed
Closed
Merged
@s1gr1d s1gr1d mentioned this issue Mar 7, 2024
Merged
mydea added a commit that referenced this issue Mar 7, 2024
@mydea
ref(browser): Update browser metrics to avoid deprecations (#10943)
b636963 
This rewrites browser metrics to:

1. Accept spans instead of transactions
2. Use the new performance APIs instead of the old ones

The only thing I left for now is the tags, which we can get rid of
separately: #10823

Part of #10900
s1gr1d added a commit that referenced this issue Mar 7, 2024
@s1gr1d
ref(svelte): Remove startChild deprecations (#10956)
e9db461 
ref #10900
@mydea mydea closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mydea