Skip to content

[v8] Refactor internal usage of span.startChild() #10901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mydea opened this issue Mar 4, 2024 · 0 comments
Closed

[v8] Refactor internal usage of span.startChild() #10901

mydea opened this issue Mar 4, 2024 · 0 comments
Assignees

Comments

@mydea
Copy link
Member

mydea commented Mar 4, 2024

Apart from #10900 & #10898, we also have two legitimate usages of span.startChild(), which is in cores trace functions, and in opentelemetrys spanExporter. We need to refactor these away. In a first step, we can replace these with manually calling new SentrySpan() and creating the span like this.

### Tasks
- [ ] Refactor `startChild()` usage in core `trace` functions
- [ ] Refactor `startChild()` usage in opentelemetry `spanExporter`
@mydea mydea self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants