-
Notifications
You must be signed in to change notification settings - Fork 326
Wait for the Dart plugin to start the DevTools server with retries #8177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8c4e79d
Only start DevTools server once
elliette 3bf0037
Rename helper method for clarity
elliette 4fdf436
Wait for the Dart Plugin to start the DevTools server with retries
elliette 7684f6f
Merge branch 'master' into issue-8144-3
elliette 93d3143
Add reload logic to AbstractDevToolsViewFactory
elliette 5543975
Clean up DevToolsServerTask
elliette 5fed9e2
Remove unused code
elliette bdfa9be
Clean up from merge
elliette 54680f4
Remove unnecessary import
elliette a1f8a86
Make sure labels are not cut off
elliette b9d2962
Respond to PR comments, make sure loading message shows up
elliette 641fd0c
PR Comments
elliette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewrite this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops autosubmit beat me to it! I will open a follow up PR monday