Wait for the Dart plugin to start the DevTools server with retries #8177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
commented
May 9, 2025
pq
approved these changes
May 9, 2025
jwren
approved these changes
May 9, 2025
helin24
approved these changes
May 9, 2025
| AsyncUtils.whenCompleteUiThread( | ||
| DevToolsService.getInstance(project).getDevToolsInstance(), | ||
| (instance, error) -> { | ||
| viewUtils.presentLabel(toolWindow, "Loading " + getToolWindowTitle() + "..."); | ||
|
|
||
| // Skip displaying if the project has been closed. |
There was a problem hiding this comment.
Oops autosubmit beat me to it! I will open a follow up PR monday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8144
This PR:
executeOnPooledThread(logic pulled intoDevToolsServerTask.java). This allows us to display the progress and cancel the server startup onforceRestart.Server start-up status:
Message if waiting for the server timed out:
Loaded Property Editor: