Skip to content

Drop support for obsolete dependencies #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2019

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jun 12, 2019

Fixes #658
Fixes #659

Description of the Change

Following specific supports are removed:

  • Python 2.7
  • Python 3.4
  • Django Filter 1.1
  • Django REST Framework >=3.8
  • Django 2.0

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk June 12, 2019 20:16
@sliverc
Copy link
Member Author

sliverc commented Jun 12, 2019

@n2ygk currently work in progress and should only be merged once #663 has been released.

One missing step is to get rid of six dependencies.

@sliverc
Copy link
Member Author

sliverc commented Jun 12, 2019

Removing six was easier than anticipated. I hope all obsolete workarounds for Python 2.7 are now removed.

I will do removing of deprecated code in another PR.

@n2ygk
Copy link
Contributor

n2ygk commented Jun 24, 2019

@sliverc I believe you need to tag this "Ready for review" since it's still labeled as a draft....

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bye bye Py2! LGTM, but @sliverc, you need to remove the draft label I believe before rebasing against master.

sliverc added 4 commits July 4, 2019 10:27
Following specific supports are removed:
* Python 2.7
* Python 3.4
* Django Filter 1.1
* Django REST Framework >=3.8
* Django 2.0
@sliverc sliverc marked this pull request as ready for review July 4, 2019 08:33
@sliverc
Copy link
Member Author

sliverc commented Jul 4, 2019

@n2ygk Added changelog and found another Py27 code snippet to be removed. Ready for final review now.

@n2ygk n2ygk merged commit 55e61e9 into django-json-api:master Jul 4, 2019
@sliverc sliverc deleted the cleanup branch July 4, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python 3.4 deprecated
2 participants