Skip to content

Release version 2.8.0 #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2019
Merged

Release version 2.8.0 #663

merged 3 commits into from
Jun 24, 2019

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Jun 12, 2019

Description of the Change

Last release before next major version 3.0.0.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk June 12, 2019 19:14
@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          57       57           
  Lines        2889     2889           
=======================================
  Hits         2778     2778           
  Misses        111      111

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be49844...429d4e3. Read the comment docs.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n2ygk n2ygk merged commit 88f7371 into django-json-api:master Jun 24, 2019
@n2ygk
Copy link
Contributor

n2ygk commented Jun 24, 2019

@sliverc OK if I create the release (for practice;-)? I need to push a v2.8.0 tag against 88f7371 and then create a new release? And then something else to push to pypi.... Hmm, maybe you should do it.

@sliverc
Copy link
Member Author

sliverc commented Jun 24, 2019

@n2ygk
I usually create the release tag on github so I can link the changelog entry in the release notes and then upload it. On PyPi I don't have the permission to manage the project but only upload and so far I don't see you having upload rights. But I am happy to do the release.

@sliverc
Copy link
Member Author

sliverc commented Jun 24, 2019

I have released it now.

@sliverc sliverc deleted the release_2_8_0 branch June 24, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants