Skip to content

Use pyupio to manage development dependencies #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2018

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 24, 2018

Description of the Change

This way CI doesn't suddenly break when a dependency has updated (e.g. #501) but we still keep up-to-date.

pyupio will open a PR with the updated dependencies once they are released.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 24, 2018 14:56
@sliverc
Copy link
Member Author

sliverc commented Oct 24, 2018

@jerel I have requested permission on org django-json-api so pyup has access. Could you grant pyupio the needed access?

@jerel
Copy link
Member

jerel commented Oct 24, 2018

@sliverc I granted it shortly after it came in. Should be working now.

Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is a chicken-or-egg problem. Maybe updating from master now that #501 is merged will make the travis flake8 step succeed.

This way CI doesn't suddently break when a dependency has updated
but we still keep up-to-date.

pyupio will open a PR with the updated dependencies.
@sliverc
Copy link
Member Author

sliverc commented Oct 25, 2018

@n2ygk
Rebased to master and CI is green now.

@n2ygk n2ygk merged commit a4d063f into django-json-api:master Oct 25, 2018
@sliverc sliverc deleted the pyupio branch October 25, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants