Skip to content

Adjust to new flake8 3.6.0 version #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2018
Merged

Adjust to new flake8 3.6.0 version #501

merged 1 commit into from
Oct 24, 2018

Conversation

sliverc
Copy link
Member

@sliverc sliverc commented Oct 24, 2018

Description of the Change

As we do not have pinned dependencies linting broke as of automatic update to 3.6.0.

Pinned flake8 version and fixed linting.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • changelog entry added to CHANGELOG.md
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 24, 2018 14:34
@sliverc sliverc changed the title Fix flake8 Adjust to new flake8 3.6.0 version Oct 24, 2018
@sliverc sliverc mentioned this pull request Oct 24, 2018
Merged
5 tasks
n2ygk
n2ygk approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging.

@n2ygk n2ygk merged commit 00fb5dc into django-json-api:master Oct 24, 2018
@sliverc sliverc deleted the fix_flake8 branch October 25, 2018 06:36
@sliverc sliverc mentioned this pull request Oct 25, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliverc @n2ygk