Skip to content

Fix NoReverseMatch import for Django >= 2.0 #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

lucacorti
Copy link
Contributor

@lucacorti lucacorti commented Dec 4, 2017

This is the same as #385 but isort is happy.

@codecov-io
Copy link

codecov-io commented Dec 5, 2017

Codecov Report

Merging #392 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   92.57%   92.57%   +<.01%     
==========================================
  Files          56       56              
  Lines        2921     2924       +3     
==========================================
+ Hits         2704     2707       +3     
  Misses        217      217
Impacted Files Coverage Δ
rest_framework_json_api/relations.py 83.14% <100%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e85cea9...3541e72. Read the comment docs.

@mblayman
Copy link
Collaborator

This is resolved by the recently merged branch that removes support for much older Django versions.

@mblayman mblayman closed this Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants