-
Notifications
You must be signed in to change notification settings - Fork 301
Fix Django deprecation warning #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amw
commented
May 7, 2017
``` RemovedInDjango20Warning: Importing from django.core.urlresolvers is deprecated in favor of django.urls ```
Codecov Report
@@ Coverage Diff @@
## develop #346 +/- ##
===========================================
+ Coverage 76.37% 76.38% +<.01%
===========================================
Files 50 50
Lines 6024 6026 +2
===========================================
+ Hits 4601 4603 +2
Misses 1423 1423
Continue to review full report at Codecov.
|
You were busy today. 😄 Thanks, @amw! 👍 |
This now breaks |
Do you mean that this fix breaks DJA on Django 2.0? Or do you mean that, because this fix is not in a released version on PyPI, DJA is broken on Django 2.0? I'm trying to figure out if the thing to fix this issue is to upload a release to PyPI. |
@mblayman Sorry, I mean this needs a PyPI release to be compatible with Django>=2.0.0 beacause the issue fixed by this this pull request has upgraded from deprecation to error in the 1.11 -> 2.0 upgrade. |
Also, this could be improved since Django 2.0.0 release notes are encouraging app authors to drop support for Django <= 1.11 so the version check on import could be removed if a new release is targeting Django>=1.11. |
Yeah, I agree. I think I need to put out a release that includes support for the older versions and the newer versions so there is a migration path, then the project can start dropping some of the older stuff (which will be nice because some of the imports are a mess). |
Yes, these two could be probably be tackled separately. A minor release as-is to make drf-ja work with Django>=2.0.0 and a new major with a larger refactoring to cleanup the compatibility stuff. |
|
See #392 |