Skip to content

Fixed invalid relationship pointer in error object #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2022
Merged

Fixed invalid relationship pointer in error object #1070

merged 3 commits into from
Jun 29, 2022

Conversation

leo-naeka
Copy link
Contributor

@leo-naeka leo-naeka commented Jun 28, 2022 •
edited
Loading

Fixes #1069

Description of the Change

  • Add failing tests for misformed relationship pointers in error payloads
  • Properly format relationship pointers in error payloads

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated N/A
  • CHANGELOG.md updated (only for user relevant changes)
    • Dunno if relevant, only fixes an expected behavior and no-one complained so far…
  • author name in AUTHORS

@sliverc sliverc self-requested a review June 29, 2022 10:01
sliverc
sliverc approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work on this. This looks good. I simply added a changelog entry as this is a bug fix a user needs to know about.

@sliverc sliverc changed the title Fix errors pointer for relationships Fixed invalid relationship pointer in error object Jun 29, 2022
@sliverc sliverc merged commit f9eb277 into django-json-api:main Jun 29, 2022
@sliverc sliverc mentioned this pull request Apr 18, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-words relation names error pointers are misformed
2 participants
@leo-naeka @sliverc