Skip to content

Multi-words relation names error pointers are misformed #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks done
leo-naeka opened this issue Jun 28, 2022 · 0 comments · Fixed by #1070
Closed
2 tasks done

Multi-words relation names error pointers are misformed #1069

leo-naeka opened this issue Jun 28, 2022 · 0 comments · Fixed by #1070
Labels
bug

Comments

@leo-naeka
Copy link
Contributor

leo-naeka commented Jun 28, 2022 •
edited
Loading

Description of the Bug Report

#986 fixed #413 but did not covered multiple words in relations names.

Therefore, when fields names formatting is enforced, pointers still refers to /attributes/ since inflection breaks field identification as a relationship.

A PR with the failing tests and the fix are on the way.

Checklist

  • Certain that this is a bug (if unsure or you have a question use discussions instead)
  • Code snippet or unit test added to reproduce bug
@leo-naeka leo-naeka added the bug label Jun 28, 2022
leo-naeka added a commit to leo-naeka/django-rest-framework-json-api that referenced this issue Jun 28, 2022
@leo-naeka
Add failing tests for misformed relationship pointers in error payloa…
d2be3f5 
…ds (django-json-api#1069)
leo-naeka added a commit to leo-naeka/django-rest-framework-json-api that referenced this issue Jun 28, 2022
@leo-naeka
Properly format relationship pointers in error payloads (django-json-…
d1e5bd8 
…api#1069)
@leo-naeka leo-naeka mentioned this issue Jun 28, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed invalid relationship pointer in error object leo-naeka/django-rest-framework-json-api
1 participant
@leo-naeka