Fix (v-c-tooltip, v-c-popover): tooltip / popover not hided on unmount of component #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoidl
added a commit
to gfoidl-Tests/Vue_Server_Test
that referenced
this pull request
Apr 25, 2022
gfoidl
added a commit
to gfoidl-Tests/Vue_Server_Test
that referenced
this pull request
Apr 26, 2022
* Updated server side
* Node updates
* Delete tests folder (tmp)
* Made project running with Vue 3 \ {tests}
* CoreUI instead of BootstrapVue 3
* Registered CoreUI components and directives in setup-coreui.ts
So not every component that uses them needs to type the imports, and the components, etc.
This approach still only imports what's needed (in the app) instead of importing all components.
* Register icons globally (lazy)
* Temporary patch for coreui/coreui-vue#203
* Restored unit-tests
* Restored vue-tests
* Restored e2e-tests (puppeteer)
* Restored e2e-full tests
* Updated CI
* Test-failure to validate CI
* Revert "Test-failure to validate CI"
This reverts commit ba82410.
* Build backend after frontend (again)
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions |
|
Please don't close. |
mrholek
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
coreui-vue/packages/coreui-vue/src/directives/v-c-tooltip.ts
Line 95 in 18d8ec4
bindingis passed in as first argument, but according to vue's documentation the first argument is theel: HtmlElement, and the second argument is thebinding.Setting a breakpoint this can be seen:
Especially when going up on frame in the stack-trace:
#183 also did this, but for tooltip only and it got closed without being merged. So the bug is still there (version 4.2.0, but all branches I check also).