refactor(CDropdown): update close button behavior

mrholek · mrholek · commit 18d8ec4bfdf4 · 2022-03-30T19:00:54.000+02:00
diff --git a/packages/coreui-vue/src/components/dropdown/CDropdownMenu.ts b/packages/coreui-vue/src/components/dropdown/CDropdownMenu.ts
@@ -37,14 +37,16 @@ const CDropdownMenu = defineComponent({
       return classNames
     }
 
-    const handleKeyup = (event: Event) => {
+    const handleKeyup = (event: KeyboardEvent) => {
       if (autoClose === false) {
         return
       }
-      if (!dropdownMenuRef.value?.contains(event.target as HTMLElement)) {
+
+      if (event.key === 'Escape') {
         hideMenu()
       }
     }
+
     const handleMouseUp = (event: Event) => {
       if (dropdownToggleRef.value?.contains(event.target as HTMLElement)) {
         return

Original file line number	Diff line number	Diff line change
`@@ -37,14 +37,16 @@ const CDropdownMenu = defineComponent({`
`37`	`37`	`return classNames`
`38`	`38`	`}`
`39`	`39`
`40`		`- const handleKeyup = (event: Event) => {`
	`40`	`+ const handleKeyup = (event: KeyboardEvent) => {`
`41`	`41`	`if (autoClose === false) {`
`42`	`42`	`return`
`43`	`43`	`}`
`44`		`- if (!dropdownMenuRef.value?.contains(event.target as HTMLElement)) {`
	`44`	`+`
	`45`	`+ if (event.key === 'Escape') {`
`45`	`46`	`hideMenu()`
`46`	`47`	`}`
`47`	`48`	`}`
	`49`	`+`
`48`	`50`	`const handleMouseUp = (event: Event) => {`
`49`	`51`	`if (dropdownToggleRef.value?.contains(event.target as HTMLElement)) {`
`50`	`52`	`return`