Skip to content

libpod: pass down NoPivotRoot to Buildah #24592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

libpod: pass down NoPivotRoot to Buildah #24592

merged 2 commits into from
Nov 18, 2024

Conversation

giuseppe
Copy link
Member

Closes: #24546

Now `podman build` honors the `no_pivot_root` setting from `containers.conf` file

@giuseppe giuseppe added the No New Tests Allow PR to proceed without adding regression tests label Nov 18, 2024
@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2024
@giuseppe giuseppe mentioned this pull request Nov 18, 2024
Closed
Luap99
Luap99 reviewed Nov 18, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@giuseppe
Copy link
Member Author

Can you add a test?

I've not managed yet to find any reliable way to detect whether --no-pivot-root was used or not, the only way I've found is using strace

@Luap99
Copy link
Member

Luap99 commented Nov 18, 2024

Mhh yeah I guess is not trivial to check and we do not seem to have any test for it on podman run either.
One idea could be to run podman from within a seccomp profile that blocks pivot_root but I guess that isn't easy to setup either.

@rhatdan
Copy link
Member

rhatdan commented Nov 18, 2024

LGTM

Luap99
Luap99 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1712594 into containers:main Nov 18, 2024
86 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 17, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pivot_root: Invalid argument during build
3 participants
@giuseppe @Luap99 @rhatdan