Skip to content

Commit 1712594

Browse files
Merge pull request #24592 from giuseppe/honor-pivot-root-build
libpod: pass down NoPivotRoot to Buildah
2 parents e195177 + e60e111 commit 1712594

File tree

13 files changed

+31
-63
lines changed

13 files changed

+31
-63
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ require (
1313
github.com/checkpoint-restore/checkpointctl v1.3.0
1414
github.com/checkpoint-restore/go-criu/v7 v7.2.0
1515
github.com/containernetworking/plugins v1.5.1
16-
github.com/containers/buildah v1.38.0
16+
github.com/containers/buildah v1.38.1-0.20241115143500-f1543bdd7d37
1717
github.com/containers/common v0.61.1-0.20241112152446-305e9ce69b0f
1818
github.com/containers/conmon v2.0.20+incompatible
1919
github.com/containers/gvisor-tap-vsock v0.8.0

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ github.com/containernetworking/cni v1.2.3 h1:hhOcjNVUQTnzdRJ6alC5XF+wd9mfGIUaj8F
7979
github.com/containernetworking/cni v1.2.3/go.mod h1:DuLgF+aPd3DzcTQTtp/Nvl1Kim23oFKdm2okJzBQA5M=
8080
github.com/containernetworking/plugins v1.5.1 h1:T5ji+LPYjjgW0QM+KyrigZbLsZ8jaX+E5J/EcKOE4gQ=
8181
github.com/containernetworking/plugins v1.5.1/go.mod h1:MIQfgMayGuHYs0XdNudf31cLLAC+i242hNm6KuDGqCM=
82-
github.com/containers/buildah v1.38.0 h1:FmciZMwzhdcvtWj+8IE+61+lfTG2JfgrbZ2DUnEMnTE=
83-
github.com/containers/buildah v1.38.0/go.mod h1:tUsHC2bcgR5Q/R76qZUn7x0FRglqPFry2g5KhWfH4LI=
82+
github.com/containers/buildah v1.38.1-0.20241115143500-f1543bdd7d37 h1:dcafNYeXF36G5/3bBR7XZtR+2IiKaHl8IWeKIbuQpY4=
83+
github.com/containers/buildah v1.38.1-0.20241115143500-f1543bdd7d37/go.mod h1:bjeQEXG0EDiLEkUmi4m7ihv6Ic1BugUF/wUfIcKBcU0=
8484
github.com/containers/common v0.61.1-0.20241112152446-305e9ce69b0f h1:K3jmJrkDJJhLnRdVFI7Gb5mv4/jb2ue9StZ2F1y2rsE=
8585
github.com/containers/common v0.61.1-0.20241112152446-305e9ce69b0f/go.mod h1:NGRISq2vTFPSbhNqj6MLwyes4tWSlCnqbJg7R77B8xc=
8686
github.com/containers/conmon v2.0.20+incompatible h1:YbCVSFSCqFjjVwHTPINGdMX1F6JXHGTUje2ZYobNrkg=

libpod/runtime_img.go

+2
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@ func (r *Runtime) Build(ctx context.Context, options buildahDefine.BuildOptions,
120120
if options.Runtime == "" {
121121
options.Runtime = r.GetOCIRuntimePath()
122122
}
123+
options.NoPivotRoot = r.config.Engine.NoPivotRoot
124+
123125
// share the network interface between podman and buildah
124126
options.NetworkInterface = r.network
125127
id, ref, err := imagebuildah.BuildDockerfiles(ctx, r.store, options, dockerfiles...)

vendor/github.com/containers/buildah/.cirrus.yml

+3-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/.codespellrc

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/Makefile

+5-36
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/copier/syscall_unix.go

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/define/build.go

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/define/types.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/imagebuildah/executor.go

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/imagebuildah/stage_executor.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/containers/buildah/install.md

+4-15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/modules.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ github.com/containernetworking/cni/pkg/version
143143
# github.com/containernetworking/plugins v1.5.1
144144
## explicit; go 1.20
145145
github.com/containernetworking/plugins/pkg/ns
146-
# github.com/containers/buildah v1.38.0
146+
# github.com/containers/buildah v1.38.1-0.20241115143500-f1543bdd7d37
147147
## explicit; go 1.22.6
148148
github.com/containers/buildah
149149
github.com/containers/buildah/bind

0 commit comments

Comments
 (0)