Bugfix/run twice

[murilopolese]

Problem:

If you press the button run twice a few breaking situation happen:

• Interrupt first execution but won't run the second time
• Sometimes get stuck on raw repl
• Sometimes run button stops working

This will also make other functions to break (save, list files, etc...)
When entering raw repl again it executes some code automatically a couple of times.
When entering raw repl, typing 'print(123)' and hitting control+D will execute and leave raw repl. It should not leave raw repl.

Solution:

Board was getting stuck because promises weren't being "canceled".
Following cue from micropython-ctl implementation: The function to reject the run promise is stored locally on board class and called before attempting other operations (stop and reset).

Future improvement:

Renaming methods because right now it's confusing what's keyboard interrupt and what is stopping a program or getting a prompt. Confusing.

[kittaakos]

I did not try it in action but read through the code changes.

[kittaakos]

This line is not necessary here, but if you want to keep setting the rejected promise to null, maybe you can have a method for all three occurrences.

function ensureRejected(message) {
  if (this.reject_run) {
    this.reject_run(new Error(message));
    this.reject_run = null;
  }
}

Any reason you prefer rejecting with a string instead of an Error?

[murilopolese]

No, it should definitely be an error. I just don't find the helper function really helpful here. I'm also not sure if this is going to be the final solution ™️ so I'd prefer keeping things a bit more unrolled.

[kittaakos]

Question: if there is an error here, and the promise is rejected, then the next run call will find this._reject_run to be not null and will reject it, but nothing will happen, as it has already been rejected. Is this expected behavior, or would it be better to set this.reject_run to null in the catch?

[kittaakos]

Thanks for the updates!