Skip to content

Bugfix/run twice #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Bugfix/run twice #57

merged 4 commits into from
Jul 5, 2023

Conversation

murilopolese
Copy link
Contributor

Problem:

Person clicks on run twice for a code with a long execution or simple stop it and editor starts misbehaving.

Interrupt first execution but won't run the second time
Sometimes get stuck on raw repl
Sometimes run button stops working
This will also make other functions to break (save, list files, etc...)

Solution:

Update front end to use new feature from micropython.js to ensure a prompt.
Here's the micropython.js PR for reference.

@murilopolese murilopolese requested a review from ubidefeo July 5, 2023 13:08
Copy link
Collaborator

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murilopolese murilopolese merged commit 4ba5831 into main Jul 5, 2023
@murilopolese murilopolese deleted the bugfix/run-twice branch July 5, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants