Skip to content

Development to Main > Release #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 53 commits into from
Dec 16, 2024
Merged

Development to Main > Release #161

merged 53 commits into from
Dec 16, 2024

Conversation

ubidefeo
Copy link
Collaborator

No description provided.

ubidefeo added 30 commits December 7, 2024 08:56
@ubidefeo
Hide navigation dots (..) when navigation path is root.
5eb412f 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Implemented keyboard shortcuts.
e159d5f 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Renamed method to onKeyboardShortcut.
bfcc2c6 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Removed whitespace.
c6d8d91 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Removed whitespace.
45a582a 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Removed leftover test code from main.js.
4c648a3 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Removed unnecessary shortcutsContext member.
ed7f839
@ubidefeo
Removed accelerator shortcuts from Menu items for Reload and Dev Tools.
9a490c2 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Implemented Board menu item.
177b7d1 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Menu cleanup.
c6ec180 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Merge branch 'fix/hide-navigation-dots' into feature/shortcuts
e9c8a2e
@ubidefeo
Merge pull request #152 from arduino/fix/hide-navigation-dots
c5b49c3 
Hide navigation dots (..) when navigation path is root.
@ubidefeo
Added ESC key listener. Enabled it on connection dialog.
1fb588e 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Ability to run code selection. Selecting whitespace runs the whole sc…
b021b25 
…ript.

Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Added Clear Terminal shortcut Meta+k.
861b658 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Polished icons.
99930a1 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Icons: updated folder.
da271ae 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Merge pull request #155 from arduino/feature/icons-update
78cd3da 
Feature/icons update
@ubidefeo
Updated micropython.js to v1.5.1
243c58e 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Testing disconnect before manual reload.
afadd3f 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Merge pull request #156 from arduino/backend/micropyton-js-v1.5.1
9baed62 
Updated micropython.js to v1.5.1
@ubidefeo
Merge branch 'development' into feature/shortcuts
1560f07
@ubidefeo
Fixed folder background.
e60703b 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Merge pull request #157 from arduino/feature/icons-update
5ce485f 
Fixed folder icon background
@ubidefeo
Merge branch 'development' into feature/shortcuts
7c6cdde
@ubidefeo
Merge pull request #154 from arduino/feature/run-code-selection
a24311d 
Ability to run code selection
@ubidefeo
Merge branch 'development' into feature/shortcuts
9a58c11
@ubidefeo
Implemented ALT option to run code selection.
88fe9a2 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Refactored menu and global shortcuts into constants file.
9908d4a 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Changed 'selection' to 'onlySelected'.
0fa99b1 
Signed-off-by: ubi de feo <[email protected]>
ubidefeo and others added 23 commits December 12, 2024 14:50
@ubidefeo
Moved registerMenu to file scope.
530dbc6 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Only save if openFile (tab) has changes.
a019c99 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Added view switch, replaced editor icon, updated shortcuts.
b051120 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Moved 'Clear Terminal' to 'View'
bd3cc3b 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Removed comments with dev notes.
9231661 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Replaced Win/Linux Ctrl+Alt+R ignored shortcut with Ctrl+Alt+S
9759ed7 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Amended shortcut handling in store.js
6432226 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Merge pull request #153 from arduino/feature/shortcuts
2bd51bb 
Feature/shortcuts
@ubidefeo
Update Board menu when opening files from File view.
5c153c0 
Signed-off-by: ubi de feo <[email protected]>
@ubidefeo
Merge pull request #159 from arduino/fix/board-menu-update-when-openi…
bc53b85 
…ng-file

Update Board menu when opening files from File view.
@sebromero
Use better name for callback
48881ce
@sebromero
Move serial logic to separate file
42f8f9c
@sebromero
Decouple UI and logic of disconnection event
cc5a8ee
@sebromero
Use serial bridge to execute serial commands
88e0bda
@sebromero
Use shared instance of Serial in menu handler
041468f
@sebromero
Remove residues from rebase
0792f2f
@sebromero
Remove code to handle reload event
c3e2bff
@sebromero
Rename folder
18c4929
@sebromero
Remove duplicated event handler
612d0b9
@sebromero
Remove event handlers on connection close
4248c1e
@sebromero
Replace existing event listeners in serial bridge
d7422b1
@sebromero
Add code documentation
b5b5219
@sebromero
Merge pull request #160 from arduino/maintenance/serial-refactoring
8d7586a 
Refactor serial connection handler - Take 2
@ubidefeo ubidefeo requested a review from sebromero December 16, 2024 19:36
sebromero
sebromero approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through the changes as they are the sum of what was already reviewed in previous PRs. Looks alright.

@ubidefeo
Copy link
Collaborator Author

Yeah, that's why we only merge into development when the results will be a solid branch which might just have a bug here and there ;)

@ubidefeo ubidefeo merged commit 3d4a54b into main Dec 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebromero sebromero sebromero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubidefeo @sebromero